Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query metrics meta via new tables #69842

Open
iambriccardo opened this issue Apr 29, 2024 · 2 comments
Open

Query metrics meta via new tables #69842

iambriccardo opened this issue Apr 29, 2024 · 2 comments
Assignees

Comments

@iambriccardo
Copy link
Member

iambriccardo commented Apr 29, 2024

New meta tables have been introduced by SNS and in this PR (#69803) functions have been exposed to query such tables.

We would like to query such data in our organization_metrics endpoints.

@iambriccardo
Copy link
Member Author

I would suggest that we create in sentry_metrics/querying/metadata new files like metrics metric_tags and metric_tag_values each of which contains the logic that fetches the data (using the functions defined in #69803).

The reason why I would propose such separation is that we need to port over some business logic from datasource like the get_stored_metrics_of_projects and it will all be in a central place.

@iambriccardo
Copy link
Member Author

iambriccardo commented Apr 29, 2024

We would also like to implement a mechanism for defining which operations are available for which entity, similarly to this:

OP_TO_SNUBA_FUNCTION = {

This would bring us into a position where we are fully independent from the old metrics layer code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants