Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(snuba): Drop bulk_snql_query #69402

Merged
merged 1 commit into from Apr 23, 2024
Merged

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Apr 22, 2024

No description provided.

@armenzg armenzg requested review from a team as code owners April 22, 2024 13:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.66%. Comparing base (64cd872) to head (48c9da4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #69402   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files        6452     6452           
  Lines      286675   286673    -2     
  Branches    49376    49376           
=======================================
- Hits       228369   228368    -1     
+ Misses      57884    57883    -1     
  Partials      422      422           
Files Coverage Δ
.../api/endpoints/organization_profiling_functions.py 96.77% <100.00%> (ø)
src/sentry/api/endpoints/organization_traces.py 98.36% <100.00%> (ø)
src/sentry/search/events/builder/metrics.py 93.38% <100.00%> (ø)
src/sentry/search/snuba/executors.py 96.37% <100.00%> (ø)
src/sentry/snuba/discover.py 79.68% <100.00%> (ø)
src/sentry/snuba/errors.py 75.47% <100.00%> (ø)
src/sentry/snuba/issue_platform.py 72.34% <100.00%> (ø)
src/sentry/snuba/metrics/datasource.py 97.34% <100.00%> (ø)
src/sentry/snuba/metrics_performance.py 92.50% <100.00%> (ø)
src/sentry/snuba/spans_metrics.py 91.83% <ø> (ø)
... and 3 more

... and 6 files with indirect coverage changes

@armenzg armenzg merged commit 4808a16 into master Apr 23, 2024
50 checks passed
@armenzg armenzg deleted the ref/build_snql_query/armenzg branch April 23, 2024 15:54
Copy link

sentry-io bot commented Apr 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SnubaError: HTTPConnectionPool(host='127.0.0.1', port=10006): Max retries exceeded with url: /generic_metrics... /api/0/organizations/{organization_slug}/metric... View Issue

Did you find this useful? React with a 👍 or 👎

armenzg added a commit that referenced this pull request Apr 24, 2024
MichaelSun48 pushed a commit that referenced this pull request Apr 25, 2024
Copy link

sentry-io bot commented Apr 25, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SnubaError: Failed to parse snuba error response /api/0/organizations/{organization_slug}/events... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants