Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send trace and span origin #2068

Open
Tracked by #14
stephanie-anderson opened this issue Jul 12, 2023 · 3 comments
Open
Tracked by #14

Send trace and span origin #2068

stephanie-anderson opened this issue Jul 12, 2023 · 3 comments
Assignees

Comments

@stephanie-anderson
Copy link
Contributor

See getsentry/team-sdks#14

@natikgadzhi
Copy link
Contributor

Reference implementation in JS SDK: https://github.com/getsentry/sentry-javascript/pull/8765/files#diff-5d0f3b11ab97c0b33599238bf8fd5d242e334bbe1f625612ab2595011c0a3c19

@st0012, @sl0thentr0py, tracing noob here. Do you think we should set origin into a Transaction, or at a Span level?

If we go with Spans:

  • Add Span.origin attr. Make sure it's serialized correctly. Default to parent_span.origin, or manual, if there's no parent span.
  • Then once that's done — we'll go over integrations that make spans and add origins to each of those invocations.

Right? What am I missing?

@sl0thentr0py
Copy link
Member

yes that's fine (on the span)

@natikgadzhi
Copy link
Contributor

Alright, I'll work on this next once I get my open PRs sorted out, unless you beat me to it.

@sl0thentr0py sl0thentr0py self-assigned this May 27, 2024
@sl0thentr0py sl0thentr0py changed the title Send trace origin Send trace and span origin May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants