Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java.Lang.IllegalArgumentException when setting MaxBreadcrumbs to 0 #3313

Open
jamescrosswell opened this issue Apr 3, 2024 · 3 comments
Open

Comments

@jamescrosswell
Copy link

Description

Originally raised in the sentry-dotnet repository (as the SDK users is building for Android using MAUI):

The exception is being thrown by the sentry-java SDK however.

@adinauer
Copy link
Member

adinauer commented Apr 4, 2024

@jamescrosswell there's BeforeBreadcrumbCallback on SentryOptions in the Java SDK, not sure if that can help create a workaround for this user by always returning null and thus dropping all breadcrumbs.

@jamescrosswell
Copy link
Author

@jamescrosswell there's BeforeBreadcrumbCallback on SentryOptions in the Java SDK, not sure if that can help create a workaround for this user by always returning null and thus dropping all breadcrumbs.

Thanks @adinauer, yes that's what I've suggested as a workaround for the time being... well technically I suggested using the SetBeforeBreadcrumb callback on the .NET options, but this gets hooked up the the Java SDK BeforeBreadcrumbCallback under the hood.

I think the customer has correctly identified a discrepancy between the docs and the SDK behaviour though so we should probably adress one or the other of those things eventually.

@stefanosiano
Copy link
Member

decision: when maxBreadcrumbs is set to 0 we should disable breadcrumbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Status: Backlog
Development

No branches or pull requests

4 participants