Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing env vars for release name detection #2050

Closed
elramen opened this issue Apr 30, 2024 · 1 comment · Fixed by #2051
Closed

Add missing env vars for release name detection #2050

elramen opened this issue Apr 30, 2024 · 1 comment · Fixed by #2051
Assignees
@elramen
Labels
Status: In Progress

Comments

@elramen
Copy link
Contributor

elramen commented Apr 30, 2024 •
edited

Looking through the SDK docs, it seems that environment variable SENTRY_RELEASE is commonly used to configure a release name. There is also an environment variable for Google App Engine used by the Python SDK. Is there a reason why the CLI does not use these? If not, they should be added to detect_release_name()
@elramen elramen self-assigned this Apr 30, 2024
@elramen elramen changed the title utils::releases env vars Add missing env vars for release name detection Apr 30, 2024
@elramen elramen mentioned this issue Apr 30, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

elramen added a commit that referenced this issue May 22, 2024
@elramen
fix(commands): Add missing env vars for release name detection (#2051)
0295c36 
Check env vars SENTRY_RELEASE and GAE_DEPLOYMENT_ID when detecting release name, as done by SDKs.

Fixes GH-2050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elramen elramen

Labels
Status: In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(commands): Add missing env vars for release name detection getsentry/sentry-cli
1 participant
@elramen