fix(commands): Add missing env vars for release name detection #2051
Conversation
|
I am not sure whether this is very useful from the CLI context, especially because we are only using the
I am more uncertain about whether checking |
|
Send-metric is going to auto-detect the release if it's not specified by the user. This is part of the metrics specification, i.e. the release tag should be added by default. Looking at the env vars checked by the Python SDK, detect_release_name() in sentry-cli checks all of them except the two added in this PR. Especially SENTRY_RELEASE seems to be a common way of setting the release across different platforms/environments. |
Check env vars SENTRY_RELEASE and GAE_DEPLOYMENT_ID when detecting release name, as this is done by SDKs
| @@ -85,7 +85,14 @@ pub fn infer_gradle_release_name(path: Option<PathBuf>) -> Result<Option<String> | |||
|
|
|||
| /// Detects the release name for the current working directory. | |||
| pub fn detect_release_name() -> Result<String> { | |||
| // cordova release detection first. | |||
| // try SENTRY_RELEASE environment variable | |||
There was a problem hiding this comment.
if the comment is almost the same as the code below it, just leave out the comment
Check env vars SENTRY_RELEASE and GAE_DEPLOYMENT_ID when detecting release name, as done by SDKs.
Fixes GH-2050