Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_envelope och send_event help msg change #2049

Closed
elramen opened this issue Apr 30, 2024 · 3 comments
Closed

send_envelope och send_event help msg change #2049

elramen opened this issue Apr 30, 2024 · 3 comments
Assignees
@elramen

Comments

@elramen
Copy link
Contributor

elramen commented Apr 30, 2024 •
edited

Remove "Check debug output for transmission errors by passing --log-level=debug" from send-envelope's and send-event's help message as this functionality does not seem to exist, e.g., turning off wifi does not give the user any error info. I believe this is a consequence of the actual transmission being handled in sentry-core which does not propagate errors back to sentry-cli.
@elramen elramen self-assigned this Apr 30, 2024
@elramen elramen mentioned this issue Apr 30, 2024
Closed
@szokeasaurusrex
Copy link
Member

Please see conversation on linked PR (#2048)

@elramen
Copy link
Contributor Author

elramen commented May 14, 2024

Added EnvelopesApi to the cli, this can be used to output error msg and return non-zero exit code on transmission failure

@elramen
Copy link
Contributor Author

elramen commented May 15, 2024

Closing in favour of #2060

@elramen elramen closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elramen elramen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(commands): Remove misleading help messages getsentry/sentry-cli
2 participants
@szokeasaurusrex @elramen