Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we really open tempfile with truncate(false)? #1989

Open
szokeasaurusrex opened this issue Mar 25, 2024 · 1 comment · May be fixed by #2073
Open

Should we really open tempfile with truncate(false)? #1989

szokeasaurusrex opened this issue Mar 25, 2024 · 1 comment · May be fixed by #2073
Assignees
@szokeasaurusrex
Labels
Status: Backlog

Comments

@szokeasaurusrex
Copy link
Member

We had to add .truncate(false) to our tempfile opening code in #1988 to fix a new Clippy lint. .truncate(false) is equivalent to the previous behavior, but it seems like it would make more sense to use truncate(true). However, when I tried truncate(true), some tests failed.

Perhaps, we should be using truncate(true), and we in fact have a bug here.
@szokeasaurusrex szokeasaurusrex self-assigned this Mar 25, 2024
@szokeasaurusrex szokeasaurusrex mentioned this issue Mar 25, 2024
Merged
@getsentry getsentry deleted a comment from github-actions bot May 29, 2024
@szokeasaurusrex
Copy link
Member Author

After investigating, I determined that truncate(false) provides the desired behavior, after all. I will prepare a PR to add comments to document why this is the case.

szokeasaurusrex added a commit that referenced this issue May 29, 2024
@szokeasaurusrex
docs: Clarify why we use truncate(false)
53c8d80 
In #1988, we added an explicit call to `truncate(false)` in our `TempFile` code to resolve a new Clippy lint. This call maintained the code's existing behavior, but [seemed like it may not have been the desired behavior](#1988 (comment)), so we opened #1989.

After investigating, we found that the `truncate(false)` call indeed provides the desired behavior.

Here, we add some comments to clarify why we use `truncate(false)` in our code.

Resolves #1989.
@szokeasaurusrex szokeasaurusrex linked a pull request May 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
Status: Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Clarify why we use truncate(false) getsentry/sentry-cli
1 participant
@szokeasaurusrex