Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add Stacktrace Option to CaptureMessage #332

Open
BigPrimeNumbers opened this issue Jun 15, 2017 · 4 comments
Open

Add Stacktrace Option to CaptureMessage #332

BigPrimeNumbers opened this issue Jun 15, 2017 · 4 comments

Comments

@BigPrimeNumbers
Copy link

It'd be great to have the option with the method captureMessage to enable a stack trace,
similar to raven-js. As of right now, it appears that captureException is the only way to get a stack trace.

@MaxBittker
Copy link
Contributor

I think this makes sense, but not going to be a high priority issue right away. Thanks @BigPrimeNumbers

@kamilogorek
Copy link
Contributor

@BigPrimeNumbers done #388
Should be released on Monday morning.

@BigPrimeNumbers
Copy link
Author

BigPrimeNumbers commented Oct 25, 2017

Very nice to see implemented, though it looks to only be supported via a global flag being set (so all calls to captureMessage will attempt to get a stacktrace if so). Maybe adding a check for it in the options sent to captureMessage would be good as well?

raven-js version of captureMessage:
https://github.com/getsentry/raven-js/blob/master/src/raven.js#L498

captureMessage: function(msg, options) {

    ...

    if (this._globalOptions.stacktrace || (options && options.stacktrace)) {
      options = objectMerge(
        {
          // fingerprint on msg, not stack trace (legacy behavior, could be
          // revisited)
          fingerprint: msg,
          // since we know this is a synthetic trace, the top N-most frames
          // MUST be from Raven.js, so mark them as in_app later by setting
          // trimHeadFrames
          trimHeadFrames: (options.trimHeadFrames || 0) + 1
        },
        options
      );

     ...

@kamilogorek
Copy link
Contributor

This is easily doable and actually will help us unify both codebases. Reopened.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants