Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

AioHttpTransportBase should accept aiohttp's client session in __init__ #22

Open
Kentzo opened this issue Oct 18, 2017 · 1 comment
Open

AioHttpTransportBase should accept aiohttp's client session in __init__ #22

Kentzo opened this issue Oct 18, 2017 · 1 comment

Comments

@Kentzo
Copy link

Kentzo commented Oct 18, 2017 •
edited

It should be mutually exclusive to other options that are used inside _client_session_factory.
User can pass it via functools.partial.
@asvetlov
Copy link

Makes sense.
Would you provide a PR?

Kentzo added a commit to GreatFruitOmsk/raven-aiohttp that referenced this issue Oct 23, 2017
@Kentzo
Allow to pass an instance of ClientSession as an argument.
d05f113 
Refs getsentry#22
Kentzo added a commit to GreatFruitOmsk/raven-aiohttp that referenced this issue Oct 23, 2017
@Kentzo
Allow to pass an instance of ClientSession as an argument.
f591bc3 
Refs getsentry#22
Kentzo added a commit to GreatFruitOmsk/raven-aiohttp that referenced this issue Oct 23, 2017
@Kentzo
Allow to pass an instance of ClientSession as an argument.
7be96f4 
Refs getsentry#22
@Kentzo Kentzo mentioned this issue Oct 23, 2017
Open
Kentzo added a commit to GreatFruitOmsk/raven-aiohttp that referenced this issue Oct 23, 2017
@Kentzo
Allow to pass an instance of ClientSession as an argument.
ada2ec4 
Refs getsentry#22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kentzo @asvetlov