Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of MAX_ORGS is not right #250

Open
mtiller opened this issue Feb 3, 2022 · 3 comments
Open

Handling of MAX_ORGS is not right #250

mtiller opened this issue Feb 3, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@mtiller
Copy link

mtiller commented Feb 3, 2022

It seems that if you provide any other value besides 1 for MELI_MAX_ORGS,
then the limit is not enforced. I scanned the code and couldn't find an obvious
source for the bug. My experience is that if you configure a server with the
MELI_MAX_ORGS value set to 5, for example, you can create as many orgs
as you want, you'll never get an error.

@gempain gempain added the bug Something isn't working label Feb 4, 2022
@gempain
Copy link
Contributor

gempain commented Feb 4, 2022

That's strange, the maxOrgsGuard is correctly placed in the createOrg handler.

@mtiller
Copy link
Author

mtiller commented Feb 4, 2022

It isn't that the guard isn't working. For the default value, it definitely prevents organizations from being created. But when I set it to 10, I was then able to make more than 10 orgs. Then if I set it to 5 (with 10+ orgs already existing) and it still allowed me to create more.

@gempain
Copy link
Contributor

gempain commented Feb 4, 2022

Oh wow okay that is really weird. I'll have a look this weekend because this is an issue. Thanks so much for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants