Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Custom headers introduce CORS issues #346

Open
doctorpangloss opened this issue Apr 29, 2024 · 0 comments
Open

[BUG]: Custom headers introduce CORS issues #346

doctorpangloss opened this issue Apr 29, 2024 · 0 comments

Comments

@doctorpangloss
Copy link

Describe the bug

Lago uses these headers:

apollographql-client-name
apollographql-client-version
x-lago-organization
customer-portal-token

among others - I have not done an exhaustive look through the codebase - which should be documented for properly configuring CORS for proxies.

It is possible that the allowed headers on production Lago is * which is maybe not fine for a billing management solution that interacts with both a proxy and Ruby.

Related to getlago/lago-helm-charts#42

To Reproduce
Visit the dashboard or the customer portal. Observe these headers will cause CORS errors on proxies configured without wildcard accepting.

Expected behavior
Document the headers needed.

Support

  • OS: (all)
  • Browser: Firefox
  • Version: 2.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant