Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config preset(s) #18

Open
getify opened this issue Mar 27, 2019 · 5 comments
Open

add config preset(s) #18

getify opened this issue Mar 27, 2019 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@getify
Copy link
Owner

getify commented Mar 27, 2019

Define one (or more) configs that make it easier to use this plugin out of the box.

Add a "configs" to the plugin definition: https://eslint.org/docs/developer-guide/working-with-plugins#configs-in-plugins

@getify getify added enhancement New feature or request help wanted Extra attention is needed labels Mar 27, 2019
@AlokTakshak
Copy link

Hi kyle,
I would like to contribute

@getify
Copy link
Owner Author

getify commented Apr 29, 2019

The way to contribute on this particular issue is to help collect information on what particular arrangement of config settings would be good as a preset default.

There's one config preset already, which is my own personal opinion on config, and can be seen here: https://github.com/getify/eslint-plugin-proper-arrows/blob/master/lib/index.js#L5-L14

I'd like for example have config presets that match (as closely as possible) the style guides of big projects like AirBnB, React, etc. But I don't know what those configs would need to be, so that needs to be researched and figured out.

Ideally, a preset could be discussed (in its own thread) and once we're all agreed on what it should consist of, then a simple PR would add it alongside the existing "getify-says" one.

@AlokTakshak
Copy link

so we have to find a proper name for config instead of 'getify-says' according to style guide of AirBnB, React, etc?

@getify
Copy link
Owner Author

getify commented Apr 29, 2019

We'll have multiple presets... One will be "getify-says", but then yes we'll name the other presets according to their purpose or intended environment.

@AlokTakshak
Copy link

AlokTakshak commented May 1, 2019

@getify
I have gone through some different plugins,
the most common are:

  1. recommended (it only changes in major version update)
    2.all
  2. strongly-recommended
  3. base
  4. recommended-with-html(in case of differnet environment)
  5. best-practices

I have one more question , as currently we have only one config-'getify-says', are we planning to add more configs for differnet environment and usecases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants