Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement request] Deleting plugin should remove yaml from config/plugins #1620

Open
jgonyea opened this issue Feb 19, 2019 · 3 comments
Open

Comments

@jgonyea
Copy link
Contributor

jgonyea commented Feb 19, 2019

When removing a plugin via the admin gui's delete button, I think the corresponding plugin's yaml file from user/config/plugins should also be removed from the filesystem. This would prevent confusion on future installations of that plugin.

@jgonyea jgonyea changed the title Deleting plugin via GUI should remove yaml from config/plugins [Enhancement request] Deleting plugin via GUI should remove yaml from config/plugins Feb 19, 2019
@jgonyea jgonyea changed the title [Enhancement request] Deleting plugin via GUI should remove yaml from config/plugins [Enhancement request] Deleting plugin should remove yaml from config/plugins Oct 17, 2019
@jgonyea
Copy link
Contributor Author

jgonyea commented Nov 2, 2019

This should probably be handled "upstream" in grav core, not just admin, as users may use the bin/gpm to uninstall items as well.

@mahagr
Copy link
Member

mahagr commented Nov 4, 2019

I think ideally there should be two ways to remove a plugin: full uninstall (purge) and partial uninstall, which keeps data and the configuration of the plugin intact in case of you need it later.

So yes, we also need to be able to delete all the other files which were added by the plugin. Should we add something to the blueprint file, so that the data locations can be registered, or do we need to add a custom uninstall script support (or both)?

@jgonyea
Copy link
Contributor Author

jgonyea commented Nov 16, 2019

Related PR: getgrav/grav#2715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants