Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default onPageNotFound priority should be -1 #1340

Closed
Flamenco opened this issue Feb 14, 2018 · 3 comments
Closed

Default onPageNotFound priority should be -1 #1340

Flamenco opened this issue Feb 14, 2018 · 3 comments

Comments

@Flamenco
Copy link
Contributor

Default onPageNotFound priority should be -1 or less.

This will allow other plugins to set the priority to 0 and still be called when they are loaded after the default fallback.

@rhukster
Copy link
Member

I 'think' you are talking about the priority in the Error plugin specifically?

https://github.com/getgrav/grav-plugin-error/blob/develop/error.php#L19

This is really not an admin plugin issue is it?

@Flamenco
Copy link
Contributor Author

I did not realize that file was in a plugin. Yes, it is the Error plugin.

@Flamenco
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants