Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and release scripts require .env file but there are no instructions in electron-react-ts readme #3

Open
pvditto opened this issue Mar 9, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@pvditto
Copy link

pvditto commented Mar 9, 2023

These scripts in the electron-react-ts example use env-cmd NPM package to read configuration from an .env file, which is not included in the repo.

The Readme should contain instructions on how to configure that file. It should also contain a sample .env file that can be modified for this task.

@pvditto pvditto added the bug Something isn't working label Mar 9, 2023
@pvditto pvditto changed the title build and release scripts require .env file but there are no instructions in Readme build and release scripts require .env file but there are no instructions in electron-react-ts readme Mar 9, 2023
@pvditto
Copy link
Author

pvditto commented Mar 9, 2023

@okdistribute would you mind having a look at this? I think you already have this set up with a working .env if I was reading your Slack convo correctly.

@okdistribute
Copy link
Collaborator

The sample is only a starting place. It only fails for building on windows.

I'd be happy if someone were to work on this more, but we don't have a ton of people using this right now.

@okdistribute okdistribute transferred this issue from getditto/samples May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants