-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We/location settings #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix restoredIncompleteOrder: this needed a single-shot return; observer-based cycled infinitely through restorable orders as each was "reset" to clear saleItemIds and set current date. Solved with new incompleteOrderFuture method - fix KDSOrderView did not update with additional saleItemIds added after initial item: solved removing `.removeDuplicates()` operator - fix saleItemIds not clearing for X-Cancel-order button action: solved by tombstoning saleItemIds MAP (rather than tombstoning all individual key/vals). Subsequent additions recreates the map and adds values implicitly - fix add "WHERE id" clause on resetQuery, clearSaleItemIdsQuery which, when failing were no-ops but would have cleared all saleItemIds in all orders
This feature allows user to switch between hard-coded restaurant demo locations and creating their own custom user-defined location. An Advanced Settings detail view added to Settings view enables switching between the two modes at runtime. - add Settings abstraction as interface to UserDefaults for persistent read/write app state variables; some DittoService-centric moved to Settings - add handling for detecting various location setup states at launch - add handling for presenting/dismissing views relating to switching modes - add AdvancedSettings detail view to SettingsView with locations mode toggle
bplattenburg
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23 #35
Meant to replace #37
This PR includes: