Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We/location settings #41

Merged
merged 16 commits into from
Apr 4, 2024
Merged

We/location settings #41

merged 16 commits into from
Apr 4, 2024

Conversation

texasRanger09
Copy link
Contributor

@texasRanger09 texasRanger09 commented Apr 2, 2024

fixes #23 #35

Meant to replace #37

This PR includes:

kndoshn and others added 16 commits March 7, 2024 18:20
- fix restoredIncompleteOrder: this needed a single-shot return; observer-based cycled
infinitely through restorable orders as each was "reset" to clear saleItemIds and set
current date. Solved with new incompleteOrderFuture method
- fix KDSOrderView did not update with additional saleItemIds added after initial item:
solved removing `.removeDuplicates()` operator
- fix saleItemIds not clearing for X-Cancel-order button action: solved by tombstoning
saleItemIds MAP (rather than tombstoning all individual key/vals). Subsequent additions
recreates the map and adds values implicitly
- fix add "WHERE id" clause on resetQuery, clearSaleItemIdsQuery  which, when failing were
no-ops but would have cleared all saleItemIds in all orders
This feature allows user to switch between hard-coded restaurant demo locations
and creating their own custom user-defined location. An Advanced Settings detail
view added to Settings view enables switching between the two modes at runtime.

- add Settings abstraction as interface to UserDefaults for persistent read/write
app state variables; some DittoService-centric moved to Settings
- add handling for detecting various location setup states at launch
- add handling for presenting/dismissing views relating to switching modes
- add AdvancedSettings detail view to SettingsView with locations mode toggle
@texasRanger09 texasRanger09 merged commit d8d99e5 into main Apr 4, 2024
@texasRanger09 texasRanger09 deleted the we/locationSettings branch April 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to change Company and Location
4 participants