Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Exporter - don't use a static id for fileprovider #72

Closed
bplattenburg opened this issue May 10, 2024 · 1 comment · Fixed by #76
Closed

Log Exporter - don't use a static id for fileprovider #72

bplattenburg opened this issue May 10, 2024 · 1 comment · Fixed by #76
Assignees
Labels

Comments

@bplattenburg
Copy link

Today, our log export tool uses a static ID for the content provider (fileprovider) in the Log Exporter tool, with no references to the host application. Because of this, you can't install 2 different apps on the same device that both include the Log Exporter tool.

Instead, we should make the ID dynamic based on the app the tool is used in, like something like $hostAppId + live.ditto.dittotoolsapp.fileprovider

@rajramsaroop
Copy link
Collaborator

Using the host app id is a suggestion, but one that makes the most sense (to me, open to more suggestions).

The particular entry in the AndroidManifest.xml is android:authorities="live.ditto.dittotoolsapp.fileprovider" - would have to look into how we can make that dynamic.

@rajramsaroop rajramsaroop self-assigned this May 17, 2024
@rajramsaroop rajramsaroop linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants