Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should GeoServerRESTStoreManager.remove throw a MalformedURLException? #219

Open
NielsCharlier opened this issue Jul 14, 2017 · 0 comments

Comments

@NielsCharlier
Copy link

NielsCharlier commented Jul 14, 2017

https://github.com/geosolutions-it/geoserver-manager/blob/master/src/main/java/it/geosolutions/geoserver/rest/manager/GeoServerRESTStoreManager.java#L103

  • It is inconsistent because none of the other methods throw this exception (create, update), even though they take the same parameters
  • Not really sure why the method changes the url string to URL and back to String ? No other method does this. Is that by accident or for a reason?
  • In any case, even if there is a reason, I think the exception treatment should be internalised. The URL is provided by the user at the creation of the restmanager and will then be verified anyways
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant