Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoServerRESTPublisher::appendParameters - ArrayIndexOutOfBoundsException #210

Open
makosteel opened this issue Mar 30, 2017 · 0 comments
Open

Comments

@makosteel
Copy link

makosteel commented Mar 30, 2017

You can get unhandled ArrayIndexOutOfBoundsException if a single parameter is passed that is empty string, this line is the cause.

Normally the code higher in the stack filters out null passed but not empties leading to this edge case, I suggest fixing this function for speed of resolution and maybe examine the higher code later, identified lines so far :

a better approach maybe to filter out the empty strings at the top method level, for example.

but i'm unsure how many functions are affected by this, all this so maybe a issue for later to go through.

I'm re-implementing the appendParameters function and submitting a pull request, will update this issue when submitted.

Pull request submitted #211

I will try and implement a test for also for this in another pull request.

Test pull request submitted #212

makosteel pushed a commit to makosteel/geoserver-manager that referenced this issue Mar 30, 2017
…t with the coverage names made empty string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant