setOutputTransparentColor on the GSImageMosaicEncoder

[thomasrideau]

Hi all,
I noticed an issue in the GSImageMosaicEncoder class: the setOutputTransparentColor method is actually write as this:
public void setOutputTransparentColor(final String val) {
removeParameter(outputTransparentColorFilter);
addInputTransparentColor(val);
}

I think the correct way should be like:
public void setOutputTransparentColor(final String val) {
removeParameter(outputTransparentColorFilter);
addOutputTransparentColor(val);
}

Is it possible to correct it to the master branch? I've never done it before.

Thanks.

Thomas

[dromagnoli]

Hi Thomas,
if you like contributing on fixing that, that would be great (that's the
spirit of open source projects ^_^).
So you could prepare the fix on your branch and create a pull request for
that so we can review it and merge to master.

If you are not so familiar with these github procedures to do that, you can
start taking a look to this:
https://guides.github.com/activities/contributing-to-open-source/#contributing

That would be the quicker way to get it fixed since sometime the devs are
very busy with several jobs/tasks resulting in need to wait some period
before they have free time to take a look to the opened issues.
Anyway, that is a very trivial fix so it wouldn't require so much time.
Please, let us know if you want to contribute fixing it.

Cheers,
Daniele

On Fri, Jan 29, 2016 at 10:22 AM, thomasrideau notifications@github.com
wrote:

Hi all,
I noticed an issue in the GSImageMosaicEncoder class: the
setOutputTransparentColor method is actually write as this:
public void setOutputTransparentColor(final String val) {
removeParameter(outputTransparentColorFilter);
addInputTransparentColor(val);
}

I think the correct way should be like:
public void setOutputTransparentColor(final String val) {
removeParameter(outputTransparentColorFilter);
addOutputTransparentColor(val);
}

Is it possible to correct it to the master branch? I've never done it
before

Thanks

Thomas

—
Reply to this email directly or view it on GitHub
#160.

GeoServer Professional Services from the experts! Visit

http://goo.gl/it488V for more information.

Ing. Daniele Romagnoli
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

---

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.