You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Furthermore, I suggest not to set logging.basicConfig in geomstats/_logging.py, which changes the config of the root logger, but operatre on logging.getLogger("geomstats"). Finally, I think that log messages of format "INFO:geomstats: ..." are much more appropriate than just "INFO:" which may be confused with logs of another library. At the very least, I would suggest changing "INFO: Using numpy backend" and similar into "INFO: geomstats is using numpy backend".
Additional information
Here is the reason I am suggesting this. We use geomstats in our GeometricKernels library, always with the numpy backend. Our library itself supports different backends (jax, torch, tensorflow, numpy), but regardless of the backend a user choses to use, they always get "INFO: Using numpy backend" from geomstats. It is extremely confusing in this case as it is unclear which library logged this message and it is hard to filter, because everything goes through the root logger.
We at GeometricKernels would really appreciate it if you could implement the suggestion above.
P.S. We cannot use geomstats with the matching backend because 1-1 mapping is impossible: geomstats does not support jax. What is more, we do not currently use any computationally demanding functions from geomstats, so there is no much need in going beyond numpy.
The text was updated successfully, but these errors were encountered:
Thanks @vabor112. This is definitely a very good suggestion. Would you be willing to do this change? If not, I'll take it whenever I find some time.
Cannot promise anything, but maybe I'll find time in the next week or two. I think the changes are quite minimal and simple, but I have never contributed to geomstats before, so there's risk that setting things up will take some time.
I just wanna bump this, as I just recently started using geomstats in a multiprocessing context and am overwhelmed with this exact same message repeatedly.
jsilter
added a commit
to jsilter/geomstats
that referenced
this issue
Mar 27, 2024
Where should the content be modified?
Throughout the library, whenever logging is used
What should be modified?
Instead of just doing
logging.info("something")
or similar, I propose usingFurthermore, I suggest not to set
logging.basicConfig
in geomstats/_logging.py, which changes the config of the root logger, but operatre on logging.getLogger("geomstats"). Finally, I think that log messages of format "INFO:geomstats: ..." are much more appropriate than just "INFO:" which may be confused with logs of another library. At the very least, I would suggest changing "INFO: Using numpy backend" and similar into "INFO: geomstats is using numpy backend".Additional information
Here is the reason I am suggesting this. We use geomstats in our GeometricKernels library, always with the
numpy
backend. Our library itself supports different backends (jax
,torch
,tensorflow
,numpy
), but regardless of the backend a user choses to use, they always get "INFO: Using numpy backend" from geomstats. It is extremely confusing in this case as it is unclear which library logged this message and it is hard to filter, because everything goes through the root logger.We at GeometricKernels would really appreciate it if you could implement the suggestion above.
P.S. We cannot use geomstats with the matching backend because 1-1 mapping is impossible: geomstats does not support
jax
. What is more, we do not currently use any computationally demanding functions from geomstats, so there is no much need in going beyondnumpy
.The text was updated successfully, but these errors were encountered: