Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for linting in the CI #1927

Open
luisfpereira opened this issue Jan 12, 2024 · 2 comments
Open

Use ruff for linting in the CI #1927

luisfpereira opened this issue Jan 12, 2024 · 2 comments
Labels
continuous integration update to continuous integration infrastructure enhancement

Comments

@luisfpereira
Copy link
Collaborator

ruff is definitely faster than flake8 (see repo README) and supports "Drop-in parity with Flake8, isort, and Black".

I think we should replace them in our CI and update pre-commit to be based on ruff.

NB: it is already used in some libraries in our ecosystem (e.g. SciPy).

Green light here, @ninamiolane? (I'm thinking about also using it in neurometry.)

@luisfpereira luisfpereira added enhancement continuous integration update to continuous integration infrastructure labels Jan 12, 2024
@ninamiolane
Copy link
Collaborator

Fantastic idea! Green light !

@ninamiolane
Copy link
Collaborator

@luisfpereira should we use the opportunity to also remove deep source ? I feel that we do not use it as much, so it's mostly making the unit tests process more cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration update to continuous integration infrastructure enhancement
Projects
None yet
Development

No branches or pull requests

2 participants