Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space of closed curves starting at origin #1925

Open
luisfpereira opened this issue Jan 9, 2024 · 0 comments
Open

Add space of closed curves starting at origin #1925

luisfpereira opened this issue Jan 9, 2024 · 0 comments
Assignees

Comments

@luisfpereira
Copy link
Collaborator

luisfpereira commented Jan 9, 2024

In #1904 we've deeply refactored discrete_curves.py. During this process, we've decided to remove the space of closed curves (ClosedDiscreteCurves), as it was not well defined. It is now time to bring it back.

How? Spatial velocities are computed using finite differences. It should suffice to make this computation "circular", i.e. add origin back to the array at the end if curve is closed.

Should I add a new space? A flag in DiscreteCurvesStartingAtOrigin (e.g. closed) should do the job, but if it becomes tricky to handle, we can add ClosedDiscreteCurvesStartingAtOrigin.

All the metrics defined for DiscreteCurvesStartingAtOrigin should work in the closed case.

Check if #1511 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Stale
Development

No branches or pull requests

2 participants