Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional functionality for ProductManifold #1706

Open
johnharveymath opened this issue Oct 20, 2022 · 0 comments
Open

Additional functionality for ProductManifold #1706

johnharveymath opened this issue Oct 20, 2022 · 0 comments
Labels
enhancement geometry geometry related content

Comments

@johnharveymath
Copy link
Collaborator

The default representation for a product manifold is a vector of points made by flattening and concatenating points from the individual factors. At runtime, for many methods, this vector is decomposed and reshaped into the individual points, acted on, and then reflattened.

However, many users may actually prefer to represent the points as lists and receive outputs as lists. It should be possible to add functionality to methods that take arrays by allowing them to alternatively take a list of n_factors arrays. This would be more efficient as the internal methods which slice and dice the arrays could be skipped.

@luisfpereira luisfpereira added enhancement geometry geometry related content labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement geometry geometry related content
Projects
None yet
Development

No branches or pull requests

2 participants