Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean namespaces, especially for RiemannianMetric #1704

Open
ninamiolane opened this issue Oct 20, 2022 · 0 comments
Open

Clean namespaces, especially for RiemannianMetric #1704

ninamiolane opened this issue Oct 20, 2022 · 0 comments

Comments

@ninamiolane
Copy link
Collaborator

ninamiolane commented Oct 20, 2022

Where should the content be modified?

No response

What should be modified?

After discussion with @LPereira95 The attributes and methods of a class should be cleaned, e.g.:

Move RiemannianMetric's

  • closest neighbor
  • distance pairwise
    to another place

Move SymmetricMatrices':

  • apply_to_eigenvalues

Discuss where to put:

  • powerm/power
  • expm goes in the backend, but Matrices.group_exp calls it

symmetric matrices is not a group thus can't have group exp, it would call the backend's expm if it needs it, because the alternative: symmetric_matrices.embedding_space.group_exp is too long and potentially not necessary. (to confirm with @ythanwerdas ).

Similar question for how to handle linear algebra computations in SymmetricMatrices: for example, use a flag is_sym that is a string, but also have a check flag that is False by default, but can be changed for development, when we actually want to check whether the input matrix is really symmetric/spd.

Note: numpy/scipy might have this type of flag system (or alternatively, several functions) to handle this linear algebra: maybe look at what they do, and follow for ease of Api.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant