Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regularize in Manifold #1703

Open
ninamiolane opened this issue Oct 20, 2022 · 0 comments
Open

Remove regularize in Manifold #1703

ninamiolane opened this issue Oct 20, 2022 · 0 comments

Comments

@ninamiolane
Copy link
Collaborator

Where should the content be modified?

geomstats/geometry/base.py Manifold class

What should be modified?

The method regularize currently is the identity function in the Manifold class.

It should be removed. We leave it up to the user who is creating their own manifold to write a method that does what regularize does. We note that the user might choose a different name for this method (not necessarily regularize) but this is not a problem since no other classes in geomstats would inherit from it.

Examples of regularize:

  • in circle: regularize(40.3 pi) --> 0.3pi
  • in mobius band
  • in klein bottle

The function regularize comes from a notion of equivalence relation between "redundant" coordinates.

The immersion in the ImmersedSet should define a domain, that specify to which domain the points should be regularized (does not say how they are regularized).

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant