You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The method regularize currently is the identity function in the Manifold class.
It should be removed. We leave it up to the user who is creating their own manifold to write a method that does what regularize does. We note that the user might choose a different name for this method (not necessarily regularize) but this is not a problem since no other classes in geomstats would inherit from it.
Examples of regularize:
in circle: regularize(40.3 pi) --> 0.3pi
in mobius band
in klein bottle
The function regularize comes from a notion of equivalence relation between "redundant" coordinates.
The immersion in the ImmersedSet should define a domain, that specify to which domain the points should be regularized (does not say how they are regularized).
Additional information
No response
The text was updated successfully, but these errors were encountered:
Where should the content be modified?
geomstats/geometry/base.py Manifold class
What should be modified?
The method regularize currently is the identity function in the Manifold class.
It should be removed. We leave it up to the user who is creating their own manifold to write a method that does what regularize does. We note that the user might choose a different name for this method (not necessarily regularize) but this is not a problem since no other classes in geomstats would inherit from it.
Examples of regularize:
The function regularize comes from a notion of equivalence relation between "redundant" coordinates.
The immersion in the ImmersedSet should define a domain, that specify to which domain the points should be regularized (does not say how they are regularized).
Additional information
No response
The text was updated successfully, but these errors were encountered: