Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlmaps search doesn't work because it uses old PDOK Locatieserver URLs #167

Open
siccovansas opened this issue Oct 31, 2023 · 3 comments · May be fixed by #168
Open

nlmaps search doesn't work because it uses old PDOK Locatieserver URLs #167

siccovansas opened this issue Oct 31, 2023 · 3 comments · May be fixed by #168

Comments

@siccovansas
Copy link

siccovansas commented Oct 31, 2023 •
edited

On https://nlmaps.nl/:

  • Scroll down to '5. Kies een zoekfunctie' and enable the 'zoekbalk'
  • Try to search for an address in the search field in the map below
  • Nothing happens
  • When you open your browser's "network" tab and try to search again you'll see HTTP 410 status codes for URLs like https://geodata.nationaalgeoregister.nl/locatieserver/v3/suggest?q=dorpstraat

PDOK has deprecated these URLs since August 2nd (issue #151 already seems to mention this as well).

I guess that many people who use nlmaps together with the search field are now broken. Can this be fixed?
@siccovansas siccovansas changed the title nlmaps search not working because it uses old PDOK Locatieserver URLs nlmaps search doesn't work because it uses old PDOK Locatieserver URLs Oct 31, 2023
@siccovansas
Copy link
Author

@emacgillavry, we are using nlmaps for https://waarismijnstemlokaal.nl/, which is visited ~1 million times during elections. We want the search to work for the upcoming elections :). Could you tell us if you don't have time to fix it? I will then fix it locally for our website.

@emacgillavry
Copy link
Contributor

@siccovansas thanks for highlighting this. I suggest you simply use LeafletJS and a standalone autocomplete library iso NLMaps which is based on older versions.

siccovansas added a commit to openstate/stembureaus that referenced this issue Nov 14, 2023
@siccovansas
Import a local version of nlmaps which changes the geocoder URL from …
61edf5d 
…the deprecated geodata.nationaalgeoregister.nl to api.pdok.nl (see also geo-frontend/nlmaps#167)
@siccovansas siccovansas linked a pull request Nov 14, 2023 that will close this issue
Open
@siccovansas
Copy link
Author

siccovansas commented Nov 14, 2023 •
edited

Thanks for your reply and advice @emacgillavry 🙏!

I've created pull request #168 which changes the deprecated URLs. This at least works for me on https://waarismijnstemlokaal.nl/.

Given that you recommend using Leaflet directly instead of NLMaps, is this project no longer maintained? If yes, it would be great if that could be announced on nlmaps.nl and in the readme of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@siccovansas @emacgillavry