Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using main as master-branch #49

Open
ThomasTJdev opened this issue May 11, 2021 · 3 comments
Open

Error when using main as master-branch #49

ThomasTJdev opened this issue May 11, 2021 · 3 comments

Comments

@ThomasTJdev
Copy link
Contributor

Currently the branch master is hardcoded, but with recent changes to Github we now see people using the name main instead. This is a problem for my library ThomasTJdev/nimlibxlsxwriter#1.

The hardcoded master is located here.

proc gitPull() =
if gGitCheckout.len() != 0:
echo "Checking out " & gGitCheckout
discard execProc("git pull --tags origin master")
discard execProc("git checkout " & gGitCheckout)
gGitCheckout = ""
else:
echo "Pulling repository"
discard execProc("git pull --depth=1 origin master")

@joshgoebel
Copy link

Also running into this exact problem and thinking perhaps this should be configurable?

@ThomasTJdev
Copy link
Contributor Author

Hi @joshgoebel

My PR #50 fixes this and allows for custom branch-naming.

But as stated in the nimgen README it has been deprecated..

Nimgen has been superseded by nimterop. Existing wrappers are slowly being migrated over to nimterop. No new features will be implemented going forward.

@genotrance
Copy link
Owner

Arguably, nimterop is also dead since I'm no longer maintaining either project. Considering c2nim is still being actively developed, I'm open to PRs and owners for nimgen. Somehow I didn't get a notification for the PR, just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants