Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'm=S' should be removed from url of query output when no more homonym #1737

Open
michelmno opened this issue Mar 23, 2024 · 7 comments
Open

Comments

@michelmno
Copy link
Contributor

just tested with last geneweb/master branch cid c62d4e5 (that merged PR #1704) and still have the two problems already commented in issue #1690:

  • in pulldown only the exterior permalink is suggested, not friend or wizard as before.
    Capture d’écran du 2024-02-14 16-53-47
  • the copied permalink do not set to 0 the occurrence field, which is a problem if more than one.
  • the original url
    http://localhost/cgi-bin/gwtst?b=testbasefusionnee_cljxdufrq&lang=fr&pz=michel&nz=normand&ocz=1&m=S&n=normand&p=henri.0
  • the copied url
    http://localhost/cgi-bin/gwtst?b=testbasefusionnee&p=henri&n=normand&lang=fr&m=S&ocz=1&nz=normand&pz=michel

Originally posted by @michelmno in #1690 (comment)

@michelmno
Copy link
Contributor Author

mea culpa, occurence number not required here.

@michelmno
Copy link
Contributor Author

mea culpa, occurence number not required here.

in fact, this is an already known problem if original url is with m=S
as originaly analysed in issue comment #1631 (comment)

http://localhost/cgi-bin/gwtst?b=testbasefusionnee_cxvgbxatn&lang=fr&pz=michel&nz=normand&ocz=1&m=S&n=normand&p=henri.0
in that case the copied permalink still has the m=S with p=henri (and not henri.0)
http://localhost/cgi-bin/gwtst?b=testbasefusionnee&p=henri&n=normand&lang=fr&m=S&ocz=1&nz=normand&pz=michel
and so the url reports all homonyms and not the only one with oc=0.

I am re-opening current issue to track the original query issue as suggested by #1631 (comment)

@michelmno michelmno reopened this Mar 24, 2024
@michelmno michelmno changed the title exterior permalink has missing occurence field 'm=S' should be removed from url of query output when no more homonym Mar 24, 2024
@hgouraud
Copy link
Collaborator

hgouraud commented Apr 17, 2024

my branch m-S should fix this problem, at least for the m=S part. I need to look more for the permalink

@michelmno
Copy link
Contributor Author

my branch m-S should fix this problem, at least for the m=S part. I need to look more for the permalink

I tested your branch with cid 7109821. Thank you this is solving the m=S part with my DB.
Wait for integration in one of your PR.

@a2line
Copy link
Collaborator

a2line commented Apr 17, 2024

Note that Henri fixed a 500 ms latency between this new bridge to a temporary homonym list of one item, so those kind of searches (if only one individual is found) imply now to two server requests: latency adapt to usage, or perhaps find another better mecasnim of bypass one day or another…

@michelmno
Copy link
Contributor Author

for tracking purpose only, problem still exist in tag: v7.1-beta.

@hgouraud
Copy link
Collaborator

yes, this has not been merged yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants