Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Save to Git" button not opening modal #8

Open
samdems opened this issue Nov 7, 2021 · 6 comments · May be fixed by #10
Open

"Save to Git" button not opening modal #8

samdems opened this issue Nov 7, 2021 · 6 comments · May be fixed by #10

Comments

@samdems
Copy link

samdems commented Nov 7, 2021 •
edited

Description

"Save to Git" button not opening Modal

Steps to reproduce

  1. Open start app and open web app
  2. click "Start new family tree"
  3. click "Save to Git"

Actual result

Nothing happens on page.

console error as follows:

vue.js:634 [Vue warn]: Error in v-on handler: "TypeError: Cannot read properties of null (reading 'open')"

(found in <Root>)
warn @ vue.js:634
logError @ vue.js:1893
globalHandleError @ vue.js:1888
handleError @ vue.js:1848
invokeWithErrorHandling @ vue.js:1871
invoker @ vue.js:2188
original._wrapper @ vue.js:7547
vue.js:1897 TypeError: Cannot read properties of null (reading 'open')
    at Vue.openGitModal ((index):449)
    at Vue.saveGit ((index):509)
    at click (eval at createFunction (vue.js:11649), <anonymous>:3:6790)
    at invokeWithErrorHandling (vue.js:1863)
    at HTMLAnchorElement.invoker (vue.js:2188)
    at HTMLAnchorElement.original._wrapper (vue.js:7547)

Expected result

Open git save modal.
image
@Zarzuelo
Copy link

I'm not sure what is exactly the problem but new-person modal is breaking git one. I moved <new-person tag after modalGit div and both work

@Zarzuelo
Copy link

Sorry, I havent seen your PR. This is exactly that Ive found

@fetsorn
Copy link

fetsorn commented Jan 29, 2022 •
edited

This is still an issue on master, PR'd @Zarzuelo's changes in #10

@fetsorn fetsorn linked a pull request Jan 29, 2022 that will close this issue
Open
@lschierer
Copy link

I was about to file a bug report that the save to git button doesn't do anything when I saw this. Hopefully it will be fixed soon.

@krionical
Copy link

As of November 2023, this issue appears to still be a problem.

@Leopere
Copy link

Leopere commented Jun 3, 2024

I hope someone still maintains this because this would be a great feature. I would love to commit a Dockerfile to make this trivial to deploy for people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move new-person to fix git modal fetsorn/genea-app
6 participants
@Leopere @lschierer @samdems @Zarzuelo @fetsorn @krionical