Skip to content
This repository has been archived by the owner on Jun 3, 2022. It is now read-only.

File filters not working on MacOS #14

Open
SolarLune opened this issue Feb 10, 2020 · 1 comment
Open

File filters not working on MacOS #14

SolarLune opened this issue Feb 10, 2020 · 1 comment

Comments

@SolarLune
Copy link
Contributor

Hello!

I've noticed a couple of issues with MacOS's File() (and by extension FileMulti()) functions' file filtering.

  • The filter argument only works for a single file extension - you can't pass, say, "jpg png" to filter out any non-image files.

  • The extension filter argument MacOS expects (jpg, for example) isn't the same format as what Linux and Windows takes (*.jpg).

I've submitted a PR to resolve these issues - #13. I also expounded on the documentation to give an idea of what a cross-platform filter argument would look like. I just wanted to create an issue here to explain it a bit in case you had some questions or wanted to discuss it a bit.

@gen2brain
Copy link
Owner

Yes, filters are messy, not just between OSes but also between Qt and GTK (zenity and qarma). My idea was to follow just one style and to handle internally all cases, but never got to do it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants