Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script ignores first argument #34

Open
mankoff opened this issue Aug 12, 2017 · 3 comments
Open

Script ignores first argument #34

mankoff opened this issue Aug 12, 2017 · 3 comments

Comments

@mankoff
Copy link

mankoff commented Aug 12, 2017

installerExists "Install macOS Sierra.app"

The script instructions say the first argument is the path to the installer, but it does no use this argument and instead looks for Sierra, then Capitan, then etc. installers. This causes confusion if you have multiple installers including Sierra, but want to run the script on something other than Sierra.

@kylegoetz
Copy link

I've created a PR to fix this and it's on my Github acct, if you're interested.

@geerlingguy
Copy link
Owner

@kylegoetz - Can you file a PR against this issue/project?

@kylegoetz
Copy link

kylegoetz commented Aug 25, 2018

I have a PR pending for this. Well it's associated with the other issue, but I think they solve the same thing: it uses the params, plus it lets you specify a tmp path if you want to use a path other than /tmp. This was important to me because I didn't have enough space on my laptop's internal drive for all the scratch work, so I added this and did the extraction/etc. on an external drive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants