Add layer loading spinner and remove layer button #1983
Conversation
|
🚀 Deployed on https://66550e576951f158dcbd210d--opengeos.netlify.app |
|
Just realized that I forgot to add a confirmation dialog when removing a layer. Will add that later |
|
I have added the confirmation dialog when removing a layer. The PR is ready for review now. spinner.mp4 |
geemap/map_widgets.py
Outdated
| @@ -6,6 +6,7 @@ | |||
| from IPython.core.display import HTML, display | |||
|
|
|||
| import ee | |||
| import ipyleaflet | |||
There was a problem hiding this comment.
We shouldn't import ipyleaflet in map_widgets. This file is supposed to be agnostic to map implementation. Two possible solutions are listed below.
-
The preferred option is to avoid this problem entirely by showing the confirmation dialog above (or inside) the existing widget. It could look like another row that's added below the row scheduled for deletion or a dialog that appears over everything.
-
Build this new "confirmation" widget as any of the other core widgets and have the widget control code live in core. The new widget needs some sort of "on_confirm_deletion" event that the code code must set. Example:
Line 683 in b115dfb
There was a problem hiding this comment.
I have implemented the preferred option 1:
another row that's added below the row scheduled for deletion
remove.layer.mp4
|
The remove layer confirmatition widget is now being displayed beneath the layer row in the layer manager. See the new demo: remove.layer.mp4 |
|
@naschmitz @jdbcode It is ready for review now. |
This PR adds a layer loading spinner and remove layer button to the layer manager. The layer widget padding is slightly reduced from
8pxto4xto make room for the two newly added buttons.layer_loading_spinner.mp4