Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Travis CI build is failing #729

Open
ckhatton opened this issue Feb 26, 2017 · 3 comments
Open

Latest Travis CI build is failing #729

ckhatton opened this issue Feb 26, 2017 · 3 comments
Labels

Comments

@ckhatton
Copy link
Member

I have found the test created by @der-On is failing because the variable 'geddy.viewHelpers' is outside the scope of the test.

I would just comment it out, but I do not know how important it is and it goes against the idea of having tests to point out issues.

I have pointed this out to Ondrej on the commit, but I am unsure if he will ever come back to me/us on it.

@mde
Copy link
Contributor

mde commented Feb 28, 2017

Async view helpers are an experimental feature. We really shouldn't have been merging commits into master that break tests. Yes, we can revert those commits.

Let me know if you can find your collaboration invitation in GitHub notifications. Once you're added to the org, you can pull those commits out!

@mde
Copy link
Contributor

mde commented Feb 28, 2017

According to GitHub, your invitation is waiting to be accepted.

@ckhatton
Copy link
Member Author

ckhatton commented Mar 1, 2017

I found it! 😃


I'm a bit of a muppet. It seems that once you've missed the email notification, you can only find it by going to the project page itself. It was a banner, stating that I was invited 27 days ago. I remember you inviting me, but I must have thought it was automatic.


I will pull those commits out, after making sure the feature branch for those commits still exists.

@ckhatton ckhatton added the Bug label Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants