Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore #726

Open
ckhatton opened this issue Feb 19, 2017 · 6 comments
Open

.gitignore #726

ckhatton opened this issue Feb 19, 2017 · 6 comments

Comments

@ckhatton
Copy link
Member

ckhatton commented Feb 19, 2017

I would like to add a .gitignore to the generated app files. Can someone tell me where I need to place it in the repo to be included?

I will then create a pull request, as I think it will be a good feature to have? 馃寠

@mde
Copy link
Contributor

mde commented Feb 19, 2017

You'll need to add it to the repo, then add it to the list of files that get copied. The gen tasks are defined here: https://github.com/geddy/geddy/blob/master/gen/jakelib/gen.jake Have a look at how the tasks in this folder work, then I can help with a little more guidance about where things go. Thanks for getting this going!

@ckhatton
Copy link
Member Author

ckhatton commented Feb 19, 2017

Thanks!

Ah I remember now... gitignore.txt is already being generated and is called on Line 176

So I will rename it to .gitignore and add what is missing. :octocat:

P.S. No probs! 馃憤

@mde
Copy link
Contributor

mde commented Feb 20, 2017

Is there maybe some reason we are starting off with it as a .txt file? It's been such a long time ago, I can't remember.

@ckhatton
Copy link
Member Author

ckhatton commented Feb 20, 2017

I think it might either be...

  • because the generator cannot see the file
  • so that one can see the file in the base folder and then later save is as .gitignore.

You would assume that one would see it, and if one does create a .gitignore an error will occur stating that the file already exists.

In the Geddy docs there are no references to the gitignore.txt file, but there are to the .gitignore file (Docs).

It reminds me and leads me to ask, how can I test the app generator after editing the files? :octocat:

@mde
Copy link
Contributor

mde commented Feb 25, 2017

You can actually run Geddy from your local branch. The symlinked geddy command is the same as running ./geddy/bin/cli.js.

@ckhatton
Copy link
Member Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants