Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to Godot 4 #48

Open
JAWS81 opened this issue May 25, 2023 · 4 comments
Open

Please update to Godot 4 #48

JAWS81 opened this issue May 25, 2023 · 4 comments

Comments

@JAWS81
Copy link

JAWS81 commented May 25, 2023

No description provided.

@IceflowRE
Copy link

Duplicate #47.

@Zifai
Copy link

Zifai commented Nov 9, 2023

Please update

@Reneator
Copy link

I am using an old version of the outline shader and it stopped working with godot 4, i stumbled on a solution that should work with many of the shaders from this repo (mostly regarding fragment functions):

godotengine/godot#49781

TL;DR: Many of the shaders can be fixed when setting color by using a "COLOR *=" instead of "COLOR =", because it seems the values are different now.

Maybe leaving this one up so people could stumble upon this could be helpful.

@Reneator
Copy link

The tip above is mostly meant to fix the "modulate set on a canvasItem gets ignored when shader is applied" and to then also be able to draw outside the texture you might need something along the lines of:

if (color.a <= 0.0) {
  COLOR = mix(color, line_color, outline - color.a);
}
else {
  COLOR *= mix(color, line_color, outline - color.a);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants