Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera rotation speed is effected by framerate. #19

Open
MJBrune opened this issue May 2, 2023 · 0 comments
Open

Camera rotation speed is effected by framerate. #19

MJBrune opened this issue May 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@MJBrune
Copy link

MJBrune commented May 2, 2023

I'd like to see the camera rotation improved in GDQuest's third-person controller. Currently, it's affected by framerate. If you turn off VSync and set max fps to 1000 (or another high number) then if you get around 400 FPS (try an empty scene) you can see the camera rotation speed become very slow. Likewise limiting to 10 FPS will speed up the camera rotation.

I noticed you multiply the rotation_input by the delta time of the physics process. This doesn't do anything though since the physics process function is fairly statically called. If you place the code to move the camera in the _process then the delta is representative of the current frame rate and thus your camera will no longer be affected by framerate.

If this is a change you'd like to see made, I'd be happy to make it.

@NathanLovato NathanLovato added the bug Something isn't working label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants