Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Movement speed coupled to camera orientation #39

Open
maystey opened this issue Apr 6, 2020 · 4 comments
Open

Movement speed coupled to camera orientation #39

maystey opened this issue Apr 6, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@maystey
Copy link

maystey commented Apr 6, 2020 •
edited

I'm submitting a...

  • [x ] Bug report.

Bug report

What is the current behavior?
Movement speed is linked to the camera angle. In particular if the camera angle is pointing upwards, the speed is greatly reduced.

What is the expected behavior?
I assume that the speed is meant to be independent of the camera angle.

Tell us the steps to reproduce the bug, and if possible share a minimal demo of the problem.

  1. Enter the main 'Game' scene
  2. Point the camera into the sky.
  3. Run around.

Other

Other information
I have a PR waiting in the wings if this is indeed a bug.
@NathanLovato NathanLovato added the bug Something isn't working label Apr 7, 2020
@NathanLovato
Copy link
Collaborator

I'm not sure if it should be considered a bug. The character moves in the camera's direction when pressing forward, so if you aim it at the ground it's normal that it moves slower than normal along the ground. But I see how it could cause issues with slopes.

What matters most to me is that the character is reactive and feels somewhat good in the hand. If removing that improves the movement's feel or the responsivity of the character, then please go ahead and open a PR.

@NathanLovato
Copy link
Collaborator

And thanks for taking the time to open issues and contribute, it's much appreciated!

@maystey
Copy link
Author

maystey commented Apr 7, 2020

You're welcome. You've given us excellent resources, it's the least I can do.

As far as the feel goes, I'm not sure. I wasn't entirely sure if this was a bug in the first place. I found it surprising that the character slowed down when looking up, but it doesn't necessarily feel bad. (Maybe with some look IK it will even seem like the most natural choice - just a thought.)

I'll push the branch where I've implemented the changes to my fork and link it to this issue thread. At the very least people can decide for themselves what they prefer and use the changes in their own implementations if they want.

maystey added a commit to maystey/godot-3d-mannequin that referenced this issue Apr 7, 2020
@maystey
Fix speed change due to camera pitch
78540a4 
** Old behaviour **
If the camera was rotated to point up or down, the speed of the
character would change. Slow down was especially noticeable when the
camera was pointed up.

** New behaviour **
The character movement speed is now independant of the camera pitch.

Related to issue gdquest-demos#39
@Braboware
Copy link

I agree that the feel is better when move speed isn't linked to the angle of the camera. I was about to open an issue myself but I saw that this was open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Braboware @NathanLovato @maystey