Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet viewer has accessibility issues #4

Open
4 tasks
qqmyers opened this issue Dec 2, 2021 · 1 comment
Open
4 tasks

Spreadsheet viewer has accessibility issues #4

qqmyers opened this issue Dec 2, 2021 · 1 comment
Labels
tracking won't fix now, but should revisit

Comments

@qqmyers
Copy link
Member

qqmyers commented Dec 2, 2021

Checking the spreadsheet viewer with Deque Axe, it reports several issues:

  • Form elements must have labels (for the upper-left corner header)
  • Table header text must not be empty (same element)
  • Table headers in a data table must refer to data cells (corner header and row headers)
  • All page content should be contained by landmarks (hidden div id=CopyPasteDiv added directly to the body)

These all appear to be problems with the HandsOnTable being used. A quick scan of their repo shows several recent accessibility issues logged, e.g. https://github.com/handsontable/handsontable/labels/Accessibility. It's not clear that these cover the issues above, but will probably mean changes are coming. We may want to look into submitting these issues and/or checking again as their issues are resolved.

@qqmyers qqmyers added the tracking won't fix now, but should revisit label Dec 2, 2021
@qqmyers
Copy link
Member Author

qqmyers commented Jan 7, 2022

I also hadn't realized that the Spreadsheet previewer loads v 0.28.4 and there are open source versions up through 11.0.1 - we should upgrade and test accessibility again. Any volunteers? I have not checked to see how much the API might have changed/how much work this might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking won't fix now, but should revisit
Projects
None yet
Development

No branches or pull requests

1 participant