Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort URL issues #5

Open
cloudhill9 opened this issue Oct 23, 2015 · 2 comments
Open

Sort URL issues #5

cloudhill9 opened this issue Oct 23, 2015 · 2 comments

Comments

@cloudhill9
Copy link

Thanks for laravel-table.

I have noticed two issues which may not be an issue at all. Please advise

  1. Not able to generate secure sort URL

  2. Trailing slash is causing 301 redirect

return url($path . '/?' . http_build_query($parameters));

gbrock added a commit that referenced this issue Oct 25, 2015
@cloudhill9
Copy link
Author

Thank you @gbrock for the quick fix.

@gbrock
Copy link
Owner

gbrock commented Oct 27, 2015

You're very welcome. Note that these fixes are only included in the upcoming rewrite; I haven't patched them into the core since it seems you've already forked for your purposes.

I'll leave this open until the fixes are available in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants