Camera visual fov fix #3307
Open
Camera visual fov fix #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove X11 call from Gazebo 7 Approved-by: Steve Peters <scpeters@osrfoundation.org> Approved-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
…#2769) * Fixed crash when collision size is zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Using ignition::math::isnan Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved error message Signed-off-by: ahcorde <ahcorde@gmail.com> * fixed method to get the name of the visual Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed else brackets Signed-off-by: ahcorde <ahcorde@gmail.com> * [Gazebo 9] Added test to check collisions equal to zero (gazebosim#2788) * Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Backport lockstep changes to gazebo9
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* add publisher private class to hold OnPublishComplete callback Signed-off-by: Ian Chen <ichen@osrfoundation.org> * std bind and rearrage pub node fini Signed-off-by: Ian Chen <ichen@osrfoundation.org> * add comment on PublisherPrivate Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…ers (gazebosim#2809) Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
…<p> (gazebosim#2825) * add test to check gazebo model generated by assimp4, see gazebosim#2682 * Length of polylist <p> is not the number of inputs (i.e. VERTEX and NORMAL) * vcount.size() * 3. If both VERTEX and NORMAL have offset 0, then the length of polylist <p> is vcount.size() * 3. So use length of set(offset) as inputSize. This fix for cases where VERTEX and NORMAL share same vcounts, see gazebosim#2682 (comment) Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
…m#2779) When an absolute path is desired, the CMAKE_INSTALL_FULL_*DIR variables should be used instead of concatenating with CMAKE_INSTALL_PREFIX. Special handling is also needed for pkg-config files.
gazebosim#2833) Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This is an adjustment to API added in gazebosim#2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
…im#2988) * Add nullptr guard in TopicManager PubToSub * Add regression test for 2875 * Port API to gazebo9 Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Signed-off-by: Jose Luis Rivero <jrivero@openrobotics.org>
…im#2991) * Add error message to RT shader * Improve error message for loading worlds/empty.world Signed-off-by: Audrow Nash <audrow@hey.com>
… the same name (Gazebo9) (gazebosim#3016) * Initial implementation of SDF checking feature Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
* Update version * Update Changelog
…gazebosim#3039) (gazebosim#3053) * Fixed ApplyWrenchDialog to properly handle nested models. * Fix improper link being selected when opening applywrenchdialog * Fixed styling issues * Test nested models in ApplyWrenchDialog + update test world * Separate nested_multilink world to avoid breaking ModelListWidget test * Fix incorrect comment * More styling fixes * Fix link name parsing to support sdformat<11 Co-authored-by: Cameron Miller <camm73@yahoo.com>
…#3031) * get ids recursively * make namespacing of ~/model/modify, ~/model/info, and server-side name setting on modify consistent * add tests for included and nested models * get scoped name by stripping parent name * move test models, add strip name test, style changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
* IncrementalPlot.cc: include qwt_scale_map.h * Use Qt::MiddleButton to fix deprecation warning * PlotCurve: add private helper for renamed members In qwt 6.2, they have renamed all member variables, so create helper functions to minimize the ifdefs we will need to support both versions. * PlotCurve: add ifdefs to support qwt 6.2.0 Signed-off-by: Steven Peters <scpeters@openrobotics.org>
We currently don't support 2021 and newer, see gazebosim#2867. Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
- Initial connection (insert) and cleanup (remove) locked with mutex - Signal (access) checks for object not null before attempting to access (not locking because would need recursive mutex) - Declare mutex as mutable so EventCount const method can block it - Include race condition test to play with connections inside an event (contribution by Sonia Jin from AWS, back port of gazebosim#3042) Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: sonia <lihui815@users.noreply.github.com>
Backport gazebosim#3031 - Make links within nested models modifiable from GUI Client
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Louise Poubel <louise@openrobotics.org>
…gazebosim#3278) * Use find_package(Python3) with newer cmake Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
approved these changes
Mar 20, 2023
|
@InigoMoreno Can you rebase to the latest gazebo11 dev? |
|
@InigoMoreno it seems that there are a lot of conflicts in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3306 by changing the dist variable. I could have also changed the width, but it could create very big images for wide angle cameras.
I did it in gazebo9, as it's the version I was testing, but it should also work on gazebo11. If someone could point me to the file where CameraVisual is in the newer versions of gazebo, looked at gz-rendering, but it doesn't seem to be any CameraVisual there.
Summary
Run the world mentioned on the issue before and after the PR.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.