Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove facebook comments integration #105

Open
kohsah opened this issue Aug 6, 2018 · 1 comment
Open

Remove facebook comments integration #105

kohsah opened this issue Aug 6, 2018 · 1 comment
Assignees

Comments

@kohsah
Copy link
Contributor

kohsah commented Aug 6, 2018

Facebook comments integration needs to be completely removed at configuration level.
Ideally, it needs to be driven by configuration. A flag set at build time should enable the facebook comments integration. NOTE: this could imply having a derived package.json which does not include facebook related packages, and the regular one that includes the packages.

@kohsah
Copy link
Contributor Author

kohsah commented Aug 13, 2018

Update:
Inlcude facebook in the build, but load it / enable it at runtime based on a flag set in the user profile.
For anonymous users facebook integration will always be disabled.
For logged in users, the facebook integration will be enabled based on a flag set in the user profile configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants