Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use COUNTRYAFF instead of COUNTRY #9

Open
tfeig opened this issue Oct 17, 2023 · 1 comment
Open

Use COUNTRYAFF instead of COUNTRY #9

tfeig opened this issue Oct 17, 2023 · 1 comment
Assignees

Comments

@tfeig
Copy link

tfeig commented Oct 17, 2023

Thanks for creating this comprehensive CSV.

I'd have one suggestion for improvement: Having an extra entry for Canarias (additionaly to mainland Spain) seems wrong as there's no such thing for other countries with disconnected areas, and it's also not in line with this statement in the README:

Version 1.0 has been updated to use the centroid of the largest land mass. This way large countries with many disparate areas (like USA, New Zealand, Chile, Portugal) have more rational center points.

@gavinr gavinr closed this as completed Oct 18, 2023
@gavinr gavinr reopened this Oct 18, 2023
@gavinr
Copy link
Owner

gavinr commented Oct 18, 2023

Hm, yeah in our data source we're using the "COUNTRY" attribute. It seems like if we use "COUNTRYAFF" attribute it may be more correct

@gavinr gavinr changed the title Remove entry for Canarias Use COUNTRYAFF instead of COUNTRY Oct 18, 2023
@gavinr gavinr self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants