Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insect Glaive Extracts? #56

Open
tanelso2 opened this issue Apr 19, 2019 · 5 comments
Open

Insect Glaive Extracts? #56

tanelso2 opened this issue Apr 19, 2019 · 5 comments

Comments

@tanelso2
Copy link

I was on Kiranico and noticed that they had the extracts per body part listed. Example

Would it be possible to have that in the app? That would really help me learn how to play Insect Glaive.

@CarlosFdez
Copy link
Member

CarlosFdez commented Apr 20, 2019

It would be possible, however short version is that it'll be unlikely unless someone contributes a full spreadsheet of monster break zones.

Joe has more or less moved on from this project, and he mentioned before that information of that sort is very time consuming to extract from the game. I'm only doing soft maintenance of this app and while I'd be willing to link up the data were I given it in any sort of predictable form (like a spreadsheet), gathering that data is extremely time consuming and I currently have other priorities.

Same goes for palico skills (and what reroll table they're on) and hunter arts (and how to unlock them).

@tanelso2
Copy link
Author

I'm pretty sure all of the information is on Kiranico so I can pull it off of there to put into the database.

It's been a while since I've done android coding but I can also try and help to contribute to the project a little bit. How would I submit a change to the database? Unzip it, change it, rezip it, then pull request that change?

@CarlosFdez
Copy link
Member

I think the best way to do this now, just in case, is to use a JSON file to represent additional information rather than modifying the database directly. Database updates often cause issues for people, so I'd like to avoid making any more database updates if possible especially while there isn't ongoing development.

So a JSON file that is loaded by the view model in the monster list to display the relevant data might be the correct call. Note that it would have to be linked by id, as the name changes based on the language.

@tanelso2
Copy link
Author

Alright. That sounds easy. Just a big map of Monster Part Id -> Extract color.

I'll get to work on constructing that. I'll take a shot at doing the android code as well and let you know if I need anything clarified. (Which I probably will because I am not an experienced Android dev)

@tanelso2
Copy link
Author

Thanks for the guidance!

I use this app every time I play mhgu so I'm excited to give back to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants