Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Seq #606

Open
loewenheim opened this issue Feb 8, 2017 · 2 comments
Open

Get rid of Seq #606

loewenheim opened this issue Feb 8, 2017 · 2 comments

Comments

@loewenheim
Copy link
Member

So it turns out that I made a mistake when I based sequents on Seq in the interest of being general. I have since learned the rule of thumb that one should use Vector in general, unless a cons list is more appropriate, then it's List. For this reason, I would like to get rid of all Seqs in data structures. 5cb5fba accomplishes this for sequents.

@gebner
Copy link
Member

gebner commented Mar 13, 2017

I have done some performance tests with Lists vs. Vectors in trepplein and was pleasantly surprised by the performance of Vector. I think we should go ahead with this change, but only for data structures. Functions should IMHO have the most general types (i.e. usually Traversable), this should avoid some unnecessary conversions for varargs.

@loewenheim
Copy link
Member Author

Alright, I'll see about changing data structures then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants