Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ganglia-logtailer should sanitize metric names #36

Open
maplebed opened this issue Apr 8, 2014 · 1 comment
Open

ganglia-logtailer should sanitize metric names #36

maplebed opened this issue Apr 8, 2014 · 1 comment

Comments

@maplebed
Copy link

maplebed commented Apr 8, 2014

ganglia-logtailer should prohibit submitting metric names that will break later in the ganglia pipeline. The main ganglia code already does some metric name sanitizing; ganglia-logtailer should apply the same rules to metric names before submitting them.
@maplebed maplebed mentioned this issue Apr 8, 2014
Merged
@maplebed
Copy link
Author

maplebed commented Apr 8, 2014

The gmond metric name sanitizing code is here: https://github.com/ganglia/monitor-core/blob/20ae85e4d7012bb2530f3f4dc37ba9075ca51f11/gmond/gmond.c#L936

looks like [A-Za-z0-9._-]

maplebed pushed a commit to maplebed/ganglia_contrib that referenced this issue Apr 8, 2014
sanitize metric names before submitting them to ganglia. ganglia#36
63be548
maplebed pushed a commit to maplebed/ganglia_contrib that referenced this issue Apr 8, 2014
sanitize metric names before submitting them to ganglia. ganglia#36
36fce90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maplebed