Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physical_view.php not compatible with PHP 8 #380

Open
iGeorgeX opened this issue Mar 5, 2024 · 1 comment
Open

physical_view.php not compatible with PHP 8 #380

iGeorgeX opened this issue Mar 5, 2024 · 1 comment

Comments

@iGeorgeX
Copy link

iGeorgeX commented Mar 5, 2024

In line 102 a

while (list($rack,) = each($racks)) {

is used and this leads to physical_view.php not running with PHP 8.

Instead of

while (list($rack,) = each($racks)) {
         # In our convention, y=0 is close to the floor. (Easier to wire up)
         krsort($racks[$rack]);
      }

It should be better

foreach ($racks as $rack => $values) {
        // In our convention, y=0 is close to the floor. (Easier to wire up)
       krsort($racks[$rack]);
      }

@berlin2123
Copy link
Contributor

fixed all 'while each()' now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants