Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] naming workerpools #60

Open
thediveo opened this issue May 23, 2022 · 0 comments
Open

[feature request] naming workerpools #60

thediveo opened this issue May 23, 2022 · 0 comments

Comments

@thediveo
Copy link

First, so many thanks for your workerpool module that is exactly what I've been looking for!

In my projects I tend to use several worker pools and I use them for transient work only, so these are not worker pools kept around all the time a service is up. Instead, I create worker pools as needed for individual requests (and there are some reasons for not sharing certain workers across different service requests).

When unit testing my service handlers for goroutine leaks (using Gomega's at this time still brand new gleak goroutine leak tester) I noticed that it would be quite nice for diagnosing if workerpools and their workers could be individually identified by some name. The name of a worker could simply be the one of its pool for simplicity. Would you be interested in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant