Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning Alpha Map from 'ExcessMapEstimator' #5247

Open
matthew-w-lundy opened this issue May 3, 2024 · 2 comments
Open

Returning Alpha Map from 'ExcessMapEstimator' #5247

matthew-w-lundy opened this issue May 3, 2024 · 2 comments
Milestone

Comments

@matthew-w-lundy
Copy link

Is your feature request related to a problem? Please describe.
Relating to #5245, identifying problems relating to acceptance in ExcessMapEstimator is difficult because only returns a FluxMap which contains no alpha information.

Describe the solution you'd like
I would like the ability to produce an alpha map with the output of ExcessMapEstimator.run().

Describe alternatives you've considered
You can generate an implied alpha map using the TS map and the On, and scaled Off but this is rather clunky and requires a user defined inverse significance function.

Additional context
Alpha is often a critical tool for assessing issues and uncertainties in significance calculations. Returning this information as a diagnostic immediately highlights potential issues when a user has selected parameters that contain issues (i.e. too small a width in their ring background). It feels clunky to add this information to the 'FluxMap' because you should be able to generate maps and significances where alpha isn't a significant factor in the calculation of the background. It could be just an optional return of 'ExcessMapeEstimator' which is what I currently do.

@matthew-w-lundy matthew-w-lundy changed the title Returing Alpha Map from 'ExcessMapEstimator' Returning Alpha Map from 'ExcessMapEstimator' May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Merci! We will respond to your issue shortly. In the meantime, try import gammapy; gammapy.song()

@registerrier
Copy link
Contributor

Thanks @matthew-w-lundy . This would useful indeed. Do you have a prototype/example implementation?

@registerrier registerrier added this to the 1.3 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants